Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify JS actions into one (rewritten flarum/action-build) #3573

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 30, 2022

Relies on flarum/action-build#10

Changes proposed in this pull request:
Unifies all frontend workflows into one.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 1.5 milestone Jul 30, 2022
@SychO9 SychO9 changed the title wip: chore: unify JS actions into one (rewritten flarum/action-build) chore: unify JS actions into one (rewritten flarum/action-build) Jul 30, 2022
@SychO9
Copy link
Member Author

SychO9 commented Aug 2, 2022

Tested on a single extension repository to make sure things are still good on that end ✅

@SychO9 SychO9 force-pushed the sm/unify-js-actions branch 2 times, most recently from f7dd8de to 54b278a Compare August 5, 2022 11:02
@SychO9
Copy link
Member Author

SychO9 commented Aug 5, 2022

Bundlewatch is disabled for now since we use a single frontend workflow. Maybe we can specifically have it only measure core dist files, or if possible all dist files at once?

@SychO9 SychO9 requested a review from davwheat August 5, 2022 13:28
@davwheat
Copy link
Member

davwheat commented Aug 8, 2022

I think disabling Bundlewatch for now is the best. We can look into re-enabling it later.

SychO9 added 3 commits August 8, 2022 13:11
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@davwheat davwheat force-pushed the sm/unify-js-actions branch from 54b278a to 1c6a8b8 Compare August 8, 2022 12:11
@davwheat
Copy link
Member

davwheat commented Aug 8, 2022

Rebased to (hopefully) pass PHP tests.

@SychO9
Copy link
Member Author

SychO9 commented Aug 8, 2022

Here goes nothing..

@SychO9 SychO9 merged commit 631b4c1 into main Aug 8, 2022
@SychO9 SychO9 deleted the sm/unify-js-actions branch August 8, 2022 13:48
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants