Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sticky nav content displays below post stream #3575

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix: sticky nav content displays below post stream #3575

merged 1 commit into from
Aug 2, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Aug 1, 2022 •
edited
Loading

Changes proposed in this pull request:

  • fixes nav bar content showing below post content

See: https://discuss.flarum.org/d/31319-dropdown-menu-is-hidden-behind-post-content/3

Reviewers should focus on:

Screenshot

image

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@davwheat davwheat added this to the 1.5 milestone Aug 1, 2022
@davwheat davwheat requested a review from SychO9 August 1, 2022 11:28
@davwheat davwheat self-assigned this Aug 1, 2022
@davwheat davwheat merged commit 61c4421 into main Aug 2, 2022
@davwheat davwheat deleted the dw/sticky-nav-layering branch August 2, 2022 09:40
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees

@davwheat davwheat

Labels
prio/high type/bug type/regression
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@davwheat @SychO9