Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(approval, likes): use subscribers #3577

Merged
merged 3 commits into from
Aug 2, 2022
Merged

chore(approval, likes): use subscribers #3577

merged 3 commits into from
Aug 2, 2022

Conversation

imorland
Copy link
Member

@imorland imorland commented Aug 2, 2022

Changes proposed in this pull request:
Swap out workaround used prior to subscribe() being made available on the settings extender.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland changed the title chore: use subscribers chore(approval, likes): use subscribers Aug 2, 2022
@imorland imorland self-assigned this Aug 2, 2022
@imorland imorland added this to the 1.5 milestone Aug 2, 2022
@imorland imorland requested review from davwheat and SychO9 August 2, 2022 09:46
davwheat
davwheat approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@imorland imorland merged commit 237076e into main Aug 2, 2022
@imorland imorland deleted the im/subscriber branch August 2, 2022 10:27
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@davwheat davwheat davwheat approved these changes

Assignees

@imorland imorland

Labels
type/cleanup
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@imorland @davwheat @SychO9 @StyleCIBot