Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: debug line slipped in while rebasing a PR #3580

Merged
merged 1 commit into from
Aug 4, 2022
Merged

chore: debug line slipped in while rebasing a PR #3580

merged 1 commit into from
Aug 4, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 4, 2022

Changes proposed in this pull request:
http://github.com/flarum/framework/pull/3418#pullrequestreview-1061446667

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9
chore: debug line slipped in while rebasing a PR
f5c9a7e 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 requested a review from imorland August 4, 2022 09:07
@SychO9 SychO9 merged commit f073c22 into main Aug 4, 2022
@SychO9 SychO9 deleted the sm/remove-debugging-leftover branch August 4, 2022 09:43
@davwheat davwheat added this to the 1.5 milestone Aug 4, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
prio/high type/bug type/regression
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @imorland @davwheat