Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compilation): versioner not inject into compilers #3589

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

luceos
Copy link
Member

@luceos luceos commented Aug 9, 2022

Fixes #3583

Changes proposed in this pull request:

While adding the revision versioner, I forgot to actually inject this versioner into the compilers. This PR solves that.

PS this change does not impact fof/nightmode as it doesn't override the method.

Reviewers should focus on:

I noticed we have zero tests (right?) for the Assets and Compilers, I don't feel these should be introduced now. But would it make sense to add an issue for that to be completed inside a 1.x release?

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@luceos luceos added this to the 1.5 milestone Aug 9, 2022
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for 1.x, in 2.0 it would be good to refactor this frontend compilation code to be more flexible. We've been more and more relying on using resolve even though core prefers not to, we can decrease that with breaking changes in 2.0 though.

Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out fine with the intended use case from an extension 👍

@luceos luceos merged commit 1d14ea6 into main Aug 9, 2022
@luceos luceos deleted the dk/3583-inject-versioner branch August 9, 2022 10:12
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilers are not build by the container
4 participants