fix(compilation): versioner not inject into compilers #3589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3583
Changes proposed in this pull request:
While adding the revision versioner, I forgot to actually inject this versioner into the compilers. This PR solves that.
PS this change does not impact fof/nightmode as it doesn't override the method.
Reviewers should focus on:
I noticed we have zero tests (right?) for the Assets and Compilers, I don't feel these should be introduced now. But would it make sense to add an issue for that to be completed inside a 1.x release?
Screenshot
Necessity
Confirmed
composer test
).Required changes: