Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor prefix matrix and add MySQL 8.0 & PHP 7.3 to workflows #3595

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 12, 2022

Changes proposed in this pull request:
See separate commits to understand changes better.

  • The first commit reduces number of actions 132 -> 106
  • The second 106 -> 132
  • The third 132 -> 197
  • The fourth 197 -> 171

To decrease the number of actions further, I have excluded from the matrix [PHP 8.0, MySQL 8.0] & [PHP 7.4, MySQL 8.0] as I don't think we need to test against all PHP versions with all possible database versions. so having two different PHP versions against MySQL 8.0 seems already plenty enough.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 4 commits August 12, 2022 13:40
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
… actions

Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 added this to the 1.5 milestone Aug 12, 2022
@SychO9 SychO9 self-assigned this Aug 12, 2022
@SychO9 SychO9 merged commit f74f7f5 into main Aug 12, 2022
@SychO9 SychO9 deleted the sm/mysql-8.0-tests branch August 12, 2022 18:22
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants