Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriptions): add missing table prefix for filter gambit #3599

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Aug 14, 2022

Changes proposed in this pull request:

Adds missing table prefix from id column reference in filter gambit constraint.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.5 milestone Aug 14, 2022
@davwheat davwheat requested review from luceos and SychO9 August 14, 2022 22:08
@davwheat davwheat self-assigned this Aug 14, 2022
davwheat added a commit to FriendsOfFlarum/follow-tags that referenced this pull request Aug 14, 2022
@luceos luceos merged commit 3d16774 into main Aug 15, 2022
@luceos luceos deleted the dw/table-prefix branch August 15, 2022 10:35
@luceos luceos mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants