Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying extensions when installing an instance #3655

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 10, 2022

Changes proposed in this pull request:
Useful when doing migrations when more than the default extensions are required to migrate the data to flarum. This allows quickly spinning up a flarum database with the necessary schema.

This use case was also raised by the work being done in https://github.com/linc/nitro-porter

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Useful when doing migrations where more than the default extensions are required to migrate the data to flarum. This allows quickly spinning up a flarum database with the necessary schema.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner October 10, 2022 14:38
Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an easy fix/addition 👍

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@imorland imorland added this to the 1.6 milestone Nov 6, 2022
@imorland imorland merged commit 69311ae into main Nov 6, 2022
@imorland imorland deleted the sm/allow-specifying-extensions-on-install branch November 6, 2022 18:43
@luceos luceos mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants