Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send notifications of a new reply when post is approved #3656

Merged
merged 2 commits into from
Nov 7, 2022
Merged

feat: send notifications of a new reply when post is approved #3656

merged 2 commits into from
Nov 7, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 12, 2022 •
edited
Loading

Changes proposed in this pull request:
Replies held for approval naturally don't send out notifications to users, however currently after a post has been approved users are still not notified that a reply has been posted.

This PR tweaks subscriptions to send notifications once a reply has been approved.

Reviewers should focus on
The code in approval was extracted into a listener because no matter what listeners are always executed before subscribers even if the extension is set to load before.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 2 commits October 11, 2022 21:43
@SychO9
test(subscriptions): approved reply sends out notifications to users
677c188 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
feat: send notifications when a post is approved
4933ac4 
The code in approval was extracted into a listener because no matter what listeners are always executed before subscribers even if the extension is set to load before.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner October 12, 2022 09:47
@SychO9 SychO9 self-assigned this Oct 15, 2022
imorland
imorland approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@imorland imorland added this to the 1.6 milestone Nov 6, 2022
@imorland imorland merged commit 62a396e into main Nov 7, 2022
@imorland imorland deleted the sm/notifications-for-approved-posts branch November 7, 2022 11:52
@luceos luceos mentioned this pull request Nov 10, 2022
Closed
@GreXXL GreXXL mentioned this pull request Nov 20, 2022
Closed
@clarkwinkelmann clarkwinkelmann mentioned this pull request Dec 26, 2022
Open
@jslirola jslirola mentioned this pull request Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

@davwheat davwheat davwheat approved these changes

Assignees

@SychO9 SychO9

Labels
type/feature
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @davwheat @imorland