Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add priorities to profile settings page #3657

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 18, 2022

Changes proposed in this pull request:
To give extensions more flexibility when it comes to where to display new items.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

To give extensions more flexibility

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner October 18, 2022 11:54
@luceos luceos merged commit 52f6148 into main Oct 18, 2022
@luceos luceos deleted the sm/add-profile-settings-priorities branch October 18, 2022 14:38
@luceos luceos added this to the 1.6 milestone Oct 18, 2022
@luceos luceos mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants