Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add statistics chart export button #3662

Merged
merged 1 commit into from
Nov 1, 2022
Merged

feat: add statistics chart export button #3662

merged 1 commit into from
Nov 1, 2022

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

  • add button to save chart to SVG file

Screenshot

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Oct 30, 2022
@davwheat davwheat requested a review from a team as a code owner October 30, 2022 23:37
@davwheat davwheat merged commit 4e5e4e5 into main Nov 1, 2022
@davwheat davwheat deleted the dw/stats-export-chart branch November 1, 2022 17:47
@luceos luceos mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@luceos luceos luceos approved these changes

Assignees

@davwheat davwheat

Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davwheat @luceos @SychO9