Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(phpstan): enable phpstan in bundled extensions #3667

Merged
merged 16 commits into from
Jan 19, 2023
Merged

chore(phpstan): enable phpstan in bundled extensions #3667

merged 16 commits into from
Jan 19, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 3, 2022 •
edited
Loading

Changes proposed in this pull request:
This a follow-up to #3666 which lays the foundation for this PR to apply PHPStan to bundled extensions.

Reviewers should focus on:

  • extend.php files.
  • General code changes.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 3, 2022 19:52
@SychO9 SychO9 self-assigned this Nov 3, 2022
@SychO9 SychO9 linked an issue Nov 4, 2022 that may be closed by this pull request
PHPStan Setup #3559
Closed
@SychO9 SychO9 changed the title chore: enable phpstan in bundled extensions chore(phpstan): enable phpstan in bundled extensions Nov 20, 2022
@SychO9 SychO9 mentioned this pull request Nov 20, 2022
Merged
8 tasks
SychO9 and others added 10 commits November 20, 2022 22:46
@SychO9
feat(phpstan): pick up extended model relations typings
3396535 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
feat(phpstan): pick up extended model date attributes
73d12e0 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
feat(core): introduce castAttribute extender
2106f00 
Stops using `dates` as it's deprecated in laravel 8

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
feat(phpstan): pick up extended model attributes through casts
577e004 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
fix: extenders not resolved when declared namespace
3c711c5 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
fix(phpstan): new model attributes are always nullable
a8bf1c1 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore(phpstan): add helpful cache clearing command
e69f9c3 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@StyleCIBot @SychO9
Apply fixes from StyleCI
700e641
@SychO9
chore: improve extend files provider logic
9d7cd90 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: rename castAttribute to just cast
182aac5 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 force-pushed the sm/phpstan-in-extensions branch from b4f0f8c to 182aac5 Compare November 20, 2022 21:47
@SychO9 SychO9 force-pushed the sm/phpstan-in-extensions-part2 branch from 57f121f to 33c8af2 Compare November 20, 2022 21:51
@SychO9
chore: update phpstan package to detect cast method
023ce97 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: enable phpstan in bundled extensions
7908e9b 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: rebasing conflicts
78afbb6 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chore: rebasing conflicts
72431b9 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 force-pushed the sm/phpstan-in-extensions-part2 branch from 75a9e0e to 72431b9 Compare November 21, 2022 17:30
@SychO9 SychO9 force-pushed the sm/phpstan-in-extensions branch from 023ce97 to ffaf722 Compare January 13, 2023 19:07
Base automatically changed from sm/phpstan-in-extensions to main January 15, 2023 14:25
@SychO9
Merge branch 'main' into sm/phpstan-in-extensions-part2
d91dd8f 
# Conflicts:
#	extensions/tags/src/Api/Serializer/TagSerializer.php
#	framework/core/src/Extend/Model.php
@SychO9 SychO9 removed the prio/high label Jan 15, 2023
@SychO9 SychO9 added this to the 1.7 milestone Jan 15, 2023
@SychO9
chore: typings for latest 1.7 changes
8e11e37 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
askvortsov1 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I love the increased consistency!

Left some comments on the previous PR that might want to be considered here or in the future

@SychO9 SychO9 merged commit da1bf8d into main Jan 19, 2023
@SychO9 SychO9 deleted the sm/phpstan-in-extensions-part2 branch January 19, 2023 20:49
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees

@SychO9 SychO9

Labels
type/cleanup
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

PHPStan Setup
3 participants
@SychO9 @askvortsov1 @StyleCIBot