Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update JS dependencies #3695

Merged
merged 4 commits into from
Nov 25, 2022
Merged

chore: update JS dependencies #3695

merged 4 commits into from
Nov 25, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 24, 2022

Fixes #3681

Changes proposed in this pull request:
To update dependencies we first lock mithril to 2.0 as 2.2 contains breaking changes. We can look into once they release a migration guide.
We also update some typing-specific changes needed as tsc has been updated.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

…no upgrade guide

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 added type/cleanup javascript Pull requests that update Javascript code labels Nov 24, 2022
@SychO9 SychO9 added this to the 1.7 milestone Nov 24, 2022
@SychO9 SychO9 requested a review from a team as a code owner November 24, 2022 12:56
Co-authored-by: David Wheatley <hi@davwheat.dev>
@SychO9 SychO9 requested a review from davwheat November 24, 2022 18:59
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine locally 👍

@SychO9 SychO9 merged commit 64fa35f into main Nov 25, 2022
@SychO9 SychO9 deleted the sm/update-js-deps branch November 25, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username text not visible in search dropdown
3 participants