Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: transpile js to es6 #3699

Merged
merged 4 commits into from
Jun 7, 2023
Merged

perf: transpile js to es6 #3699

merged 4 commits into from
Jun 7, 2023

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Nov 27, 2022

Changes proposed in this pull request:

  • output ES6 Javascript instead of ES5

All extension JS source code will need to be recompiled with an updated Webpack config.

This will reduce our tech debt and overall bundle size due to unneeded ES5 polyfills included by Babel despite us not supporting any ES5 browsers.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@davwheat davwheat self-assigned this Nov 27, 2022
@davwheat davwheat added this to the 2.0 milestone Nov 27, 2022
@davwheat davwheat changed the title perf: transpile to es6 perf: transpile js to es6 Nov 27, 2022
@SychO9 SychO9 changed the base branch from main to 2.x May 27, 2023 17:42
@SychO9 SychO9 force-pushed the dw/transpile-es6 branch from f1c596a to 2c859b9 Compare May 30, 2023 17:24
@SychO9
Copy link
Member

SychO9 commented May 31, 2023

@davwheat is this complete?

@davwheat
Copy link
Member Author

Yeah, I think so. I only marked it as draft because we weren't 2.x-dev ready then.

@SychO9 SychO9 marked this pull request as ready for review May 31, 2023 15:31
@SychO9 SychO9 requested a review from a team as a code owner May 31, 2023 15:31
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label May 31, 2023
@SychO9 SychO9 merged commit 12ef1bf into 2.x Jun 7, 2023
@SychO9 SychO9 deleted the dw/transpile-es6 branch June 7, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants