-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add user creation to users list page #3744
Conversation
Do we want to allow setting a password by default? Wouldn't it make more sense to create a temporary one instead? And then hook into the password reset logic? |
I think both are valid options, and I was thinking about that myself. Maybe an option to "force user to reset password to log in"? Question is whether we want to automatically fire the reset pwd email or just state that the user should reset their own password? Or should we have a separate "someone's made an account for you on xyz", but that's straying into extension territory imo. |
1251f5d
to
2dbf330
Compare
I've opted to generate a random password on the client-side and provide that, but I do wonder if it's better to generate it in the backend and automate the forgotten password email instead? But I feel a forgotten password for a new user on a site they haven't used yet would be very confusing. |
@davwheat what's the situation here? Do you have time to complete these changes so this can be merged, or shall we tackle it? |
Someone else can take it, if they'd like. I don't have the time this week or next. |
# Conflicts: # framework/core/js/src/admin/components/UserListPage.tsx
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Supersedes #2998
Progresses #3742
Changes proposed in this pull request:
Screenshot
Necessity
Confirmed
composer test
).