Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tags): not all tags are loaded in the permission grid #3804

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix(tags): not all tags are loaded in the permission grid #3804

merged 1 commit into from
Apr 21, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 20, 2023

Fixes #3800

Changes proposed in this pull request:

  • The code was just getting all tags from the store, this PR changes the state to make sure to consider first load.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9
fix(tags): not all tags are loaded in the permission grid
f595182 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 20, 2023 20:08
askvortsov1
askvortsov1 approved these changes Apr 20, 2023
View reviewed changes
extensions/tags/js/src/common/states/TagListState.ts
return this.query(unloadedIncludes);
}

async query(includes: string[] = []): Promise<Tag[]> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this protected?

@imorland imorland added this to the 1.8 milestone Apr 21, 2023
@imorland imorland added the javascript Pull requests that update Javascript code label Apr 21, 2023
@imorland imorland merged commit 803f0cd into main Apr 21, 2023
@imorland imorland deleted the sm/3800-tags-permission-grid branch April 21, 2023 06:38
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/bug
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Permission grid doesn't show all the tags
4 participants
@SychO9 @davwheat @askvortsov1 @imorland