Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase phpstan level to 6 #3836

Merged
merged 2 commits into from
Jun 21, 2023
Merged

chore: increase phpstan level to 6 #3836

merged 2 commits into from
Jun 21, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jun 21, 2023

Changes proposed in this pull request:
Increases the level to 6 for better static code analysis. The plan was to keep going till level 8, but I noticed a lot of false positives on that level, and while most of them can be fixed by ignoring specific errors, I think it'd be better to stick to this level for now.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

SychO9 and others added 2 commits June 21, 2023 09:28
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 added this to the 2.0 milestone Jun 21, 2023
@SychO9 SychO9 requested a review from a team as a code owner June 21, 2023 08:36
@SychO9 SychO9 requested a review from imorland June 21, 2023 08:36
@imorland imorland merged commit 5820a16 into 2.x Jun 21, 2023
@imorland imorland deleted the sm/phpstan-increased-level branch June 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants