fix(regression): Webpack not working on Windows with new export registry #3855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #3842.
Changes proposed in this pull request:
path.relative
for module path/
Initially, since
.replace()
was hardcoding/
, the entire absolute path was being added toflarum.reg.add()
.Then, building still errored because it was using
\
as path separators, and the following characters weren't valid escape sequences.Tried to use
path.posix
, but it can't normalize win32 paths into unix. There's a package for that (slash), but it basically just replaces\
with/
- I don't think this implementation should cause any issues.QA
Build JS. Dist remains the exact same.
Necessity
Confirmed
Backend changes: tests are green (runcomposer test
).