Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1.x,suspend): suspended users can abuse avatar upload #3890

Merged
merged 3 commits into from
Sep 22, 2023
Merged

fix(1.x,suspend): suspended users can abuse avatar upload #3890

merged 3 commits into from
Sep 22, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 20, 2023

Changes proposed in this pull request:
Suspended users can abuse the avatar upload functionality. This prevents that y denying access.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner September 20, 2023 17:42
@SychO9 SychO9 added this to the 1.8.2 milestone Sep 20, 2023
@SychO9 SychO9 requested a review from imorland September 20, 2023 17:43
imorland
imorland approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested locally, but this seems sound 👍

Would be nice to have a test for this too?

@imorland imorland merged commit b1383a9 into 1.x Sep 22, 2023
263 checks passed
@imorland imorland deleted the sm/suspended-can-abuse-avatar-upload branch September 22, 2023 18:38
@matteocontrini
Copy link
Contributor

The corresponding issue should be closed: flarum/issue-archive#214

@SychO9 SychO9 mentioned this pull request Sep 27, 2023
Closed
@imorland imorland mentioned this pull request Jun 16, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@SychO9 @matteocontrini @imorland @StyleCIBot