Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ::class syntax to fetch class name instead of get_class() function #3910

Merged
merged 1 commit into from
Oct 29, 2023
Merged

chore: use ::class syntax to fetch class name instead of get_class() function #3910

merged 1 commit into from
Oct 29, 2023

Conversation

datlechin
Copy link
Contributor

This pull request updates the codebase to use the ::class syntax for obtaining the fully qualified class name from objects. This improvement aligns with the introduction of this syntax in PHP 8.0.

See more: https://wiki.php.net/rfc/class_name_literal_on_object

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner October 26, 2023 15:30
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luceos
Copy link
Member

luceos commented Oct 28, 2023

What a simple, but useful addition. @datlechin thank you 🙏

@imorland imorland added this to the 2.0 milestone Oct 29, 2023
@SychO9 SychO9 merged commit 015529f into flarum:2.x Oct 29, 2023
17 checks passed
@datlechin datlechin deleted the fetch-class-on-object branch October 29, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants