Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid using .fa() mixins and @fa-var vars #3912

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 27, 2023

Changes proposed in this pull request:

  • These were a problem in 1.x when we attempted to upgrade to fontawesome 6, they also pose an issue with regards to possibly moving away from using LESS because of the compiler.
  • It's also generally easier to have explicit icon elements and switch between them.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 2.0 milestone Oct 27, 2023
@SychO9 SychO9 requested a review from a team as a code owner October 27, 2023 16:07
@SychO9 SychO9 merged commit 87a83d3 into 2.x Oct 29, 2023
22 checks passed
@SychO9 SychO9 deleted the sm/remove-fa-icons-from-less branch October 29, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants