Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve debugging experience #3944

Merged
merged 1 commit into from
Jan 9, 2024
Merged

chore: improve debugging experience #3944

merged 1 commit into from
Jan 9, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Dec 13, 2023

Changes proposed in this pull request:

  • Auto displays the error modal with evaluated var dumper output when the API returns 500 and we are in debugging mode.
  • This improves the development/debugging experience for developers

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner December 13, 2023 17:19
imorland
imorland reviewed Dec 16, 2023
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE this idea, this will absolutely help with debugging!

One thing, unless I missed it somewhere else, won't we need symfony/var-dumper added to our deps?

@SychO9
Copy link
Member Author

SychO9 commented Dec 16, 2023

already is 👍🏼

https://github.com/flarum/framework/blob/2.x/framework/core/composer.json#L98
https://github.com/flarum/framework/blob/2.x/composer.json#L172

@imorland
Copy link
Member

🤦‍♂️

@imorland imorland added this to the 2.0 milestone Jan 9, 2024
@imorland imorland merged commit c1be00e into 2.x Jan 9, 2024
25 of 29 checks passed
@imorland imorland deleted the sm/auto-display-error-modal branch January 9, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @imorland