[1.x] fix: reset admin page save button in catch handler #3963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3962
Changes proposed in this pull request:
Add a catch handler to
saveSettings()
to reset admin page's save button state.Reviewers should focus on:
Should a newly added function that only sets
loading
tofalse
be created.Screenshot
No much changes will be shown to users.
QA
Create a
Saving
event listener and throw an exception to create a saving error.Necessity
Confirmed
composer test
).Required changes: