Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option for filtering read stickied on all discussions page #4073

Merged
merged 5 commits into from
Oct 17, 2024
Merged

feat: add option for filtering read stickied on all discussions page #4073

merged 5 commits into from
Oct 17, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 17, 2024

Reopened #3995

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

adrianmccay and others added 5 commits May 29, 2024 17:57
@adrianmccay
feat: add option for filtering read stickied on all discussions page
b0f7c7c
@adrianmccay
linting issues
d87199f
@adrianmccay
Changes based on PR feedback
ad481e2
@SychO9
Merge branch '2.x' into am/2.x-add-option-for-filtering-read-from-sti…
cb483b1 
…ckies-on-all-discussions

# Conflicts:
#	extensions/sticky/src/PinStickiedDiscussionsToTop.php
#	extensions/sticky/tests/integration/api/ListDiscussionsTest.php
@SychO9
Merge branch '2.x' into am/2.x-add-option-for-filtering-read-from-sti…
b8d0a24 
…ckies-on-all-discussions

# Conflicts:
#	extensions/sticky/js/src/admin/extend.tsx
@SychO9 SychO9 requested a review from a team as a code owner October 17, 2024 09:13
@SychO9 SychO9 changed the title Am/2.x add option for filtering read from stickies on all discussions feat: add option for filtering read stickied on all discussions page Oct 17, 2024
@SychO9 SychO9 mentioned this pull request Oct 17, 2024
Closed
10 tasks
@SychO9 SychO9 added this to the 2.0 milestone Oct 17, 2024
@SychO9 SychO9 merged commit 876a964 into 2.x Oct 17, 2024
21 of 24 checks passed
@SychO9 SychO9 deleted the am/2.x-add-option-for-filtering-read-from-stickies-on-all-discussions branch October 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @adrianmccay