Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new password rule language line #151

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Add new password rule language line #151

merged 1 commit into from
Aug 14, 2020

Conversation

qiaeru
Copy link
Contributor

@qiaeru qiaeru commented Dec 31, 2019

@dsevillamartin
Copy link
Member

This is only used in Laravel v6.2 and later. Flarum currently uses Laravel v5.7, and future plans about updating to v6 are unknown, so this line won't be used at all for the time until that happens.

@qiaeru
Copy link
Contributor Author

qiaeru commented Dec 31, 2019

Laravel 6.x lines are already included, so I don't see why we shouldn't include this one (or we should remove other lines?).

@dsevillamartin
Copy link
Member

dsevillamartin commented Dec 31, 2019

Unless I'm seeing this wrong, the line won't be used until we update to Laravel v6.2+. Not sure what other lines you are talking about in validation.yml being from v6 as well.

The only one I can see that wouldn't be used is ends_with (90a31d5) as that was added in v5.8, and we use v5.7.

@qiaeru
Copy link
Contributor Author

qiaeru commented Jan 5, 2020

You're correct, I hadn't seen the compatibilities.

ends_with starts with 5.8.17 and password starts with 6.2.0.

@qiaeru
Copy link
Contributor Author

qiaeru commented Aug 8, 2020

Bump. Flarum uses Laravel 6 now, am I wrong?

flarum/framework@9c09fe8

@franzliedke franzliedke merged commit 5a071d9 into flarum:master Aug 14, 2020
@franzliedke
Copy link
Contributor

Thanks 🙏

askvortsov1 pushed a commit that referenced this pull request Mar 11, 2022
See: laravel/laravel@050c1d8

Co-authored-by: Miles Cellar <milescellar@users.noreply.github.com>
askvortsov1 pushed a commit that referenced this pull request May 10, 2022
See: laravel/laravel@050c1d8

Co-authored-by: Miles Cellar <milescellar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants