-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added translations for Send Test Mail feature #156
Added translations for Send Test Mail feature #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort keys alphabetically!
This requirement is really annoying for translators. Order of strings may give some hints about the context for specific phrase. Forcing alphabetical order is just more work for devs to create less useful resource... |
@rob006 I understand your concern, but want to provide some nuance:
It's a trade-off, as with many things. So far, I personally have been very happy with it. |
It is not the only one, it is just the simplest one. Ordering by file name and line number is also consistent, but in addition it is also natural (it is common convention for extractors generating pot files). It is also debatable whether you need convention here at all. This file is created by humans for humans, why do you need to follow rule typical for machines? You don't order methods in your classes alphabetically...
I'm guessing you're not using these files. :P |
Resolved by moving the translations to the api section, where they belong (this section is for emails that are sent only). I left subject before body, as that is the convention with the rest of these. |
912201a
to
1e2c822
Compare
* Added translations for Send Test Mail feature
* Added translations for Send Test Mail feature
Companion PR to flarum/framework#2023