Optimize tag permissions #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new implementation generates a subquery of IDs instead of sending big arrays of data to/from the database. This massively speeds up performance.
This was referenced Apr 24, 2021
SychO9
requested changes
Apr 29, 2021
tankerkiller125
approved these changes
May 3, 2021
SychO9
reviewed
May 4, 2021
SychO9
approved these changes
May 4, 2021
askvortsov1
added a commit
that referenced
this pull request
Mar 11, 2022
The new implementation generates a subquery of IDs instead of sending big arrays of data to/from the database. This massively speeds up performance.
askvortsov1
added a commit
that referenced
this pull request
May 10, 2022
The new implementation generates a subquery of IDs instead of sending big arrays of data to/from the database. This massively speeds up performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to check the tags where users have permissions, we:
whereIn.This is quite slow. Instead of doing this, this PR creates a subquery for all tags where a user has a permission, then feeds that subquery to
whereIns. Combined with #87, this makes a setup with:have negligible effects on initial page load.
Most of this PR is tests, don't be scared of the line changes!