Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Electra payloads #651

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add support for Electra payloads #651

wants to merge 10 commits into from

Conversation

jtraglia
Copy link
Collaborator

@jtraglia jtraglia commented Apr 29, 2024

πŸ“ Summary

This PR adds support for Electra payloads.

β›± Motivation and Context


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@jtraglia jtraglia marked this pull request as ready for review May 9, 2024 14:31
avalonche
avalonche previously approved these changes May 15, 2024
Copy link
Collaborator

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are tests for this going to be a follow up PR?

@jtraglia
Copy link
Collaborator Author

LGTM, are tests for this going to be a follow up PR?

Yes, I'm planning to add tests later. Please hold off on merging this for a little bit. We're working on getting the whole Electra builder stack working in Kurtosis this week. Thank you for reviewing though πŸ˜„

I'm fairly confident in these mev-boost changes, but mev-boost-relay will need some more work.

metachris
metachris previously approved these changes Jul 24, 2024
Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types are out of date by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants