feat: add build arg RBUILDER_BIN to dockerfile #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasbusa
requested review from
dvush,
ZanCorDX,
metachris,
jakubhruby7 and
ferranbt
as code owners
barnabasbusa
changed the title
ryanschneider
approved these changes
Nov 5, 2024
Benchmark results for
|
| Date (UTC) | 2024-11-05T18:14:39+00:00 |
| Commit | 357977eff16c3b4fe142b6600df9ce86f5e2a893 |
| Base SHA | 0a2e73e123c3d48777eac53c816f72630d06d017 |
Significant changes
None
ferranbt
approved these changes
Nov 5, 2024
barnabasbusa
added a commit
to ethpandaops/eth-client-docker-image-builder
that referenced
this pull request
Nov 20, 2024
depends on flashbots/rbuilder#237 --------- Signed-off-by: Barnabas Busa <busa.barnabas@gmail.com>
grasphoper
pushed a commit
to grasphoper/rbuilder
that referenced
this pull request
Nov 27, 2024
## 📝 Summary Adds `RBUILDER_BIN` build arg to Dockerfile so that a docker image for `reth-rbuilder` can be built as well. ## 💡 Motivation and Context <!--- (Optional) Why is this change required? What problem does it solve? Remove this section if not applicable. --> --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test