Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bundle merger #298

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Move bundle merger #298

merged 5 commits into from
Dec 19, 2024

Conversation

ZanCorDX
Copy link
Contributor

📝 Summary

For historical reasons, bundle merging logic (MultiShareBundleMerger) had to be implemented on each algorithm but that's not needed anymore so I removed MultiShareBundleMerger from both algorithms and added it in a single point between simulation and block building.

💡 Motivation and Context

  • The way it was before made implementing new algorithms more difficult.
  • Removed redundant calculations.

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copy link

Benchmark results for 24044d6

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/24044d6-8989fca/report/index.html

Date (UTC) 2024-12-18T21:44:41+00:00
Commit 24044d643bf8e7101ee187b5f6496e887545f0d2
Base SHA 8989fca4e065fee013fd3d4aec225e4847cc3028

Significant changes

Benchmark Mean Status
hashing_3000_elements -4.32% Performance has improved.

@ZanCorDX ZanCorDX merged commit b2a21b1 into develop Dec 19, 2024
6 checks passed
@ZanCorDX ZanCorDX deleted the move-bundle-merger branch December 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants