New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed SimulatedOrder::prev_order since it was not used. #311

Open

ZanCorDX wants to merge 1 commit into develop from kill-prev_order

+1 −17

Contributor

ZanCorDX commented Dec 19, 2024

📝 Summary

Removed SimulatedOrder::prev_order since it was not used.

💡 Motivation and Context

Unused members make the rbuilder less aerodynamic.

✅ I have completed the following steps:

Run make lint
Run make test
Added tests (if applicable)


          removed

b832b8c

ZanCorDX requested review from dvush, ferranbt and liamaharon as code owners

December 19, 2024 19:15

github-actions bot commented Dec 19, 2024

Benchmark results for `b832b8c`

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/b832b8c-b2a21b1/report/index.html


Date (UTC)	2024-12-19T19:16:34+00:00
Commit	`b832b8cc16aaf09448d7e92e8e9be89ac4fcbf22`
Base SHA	`b2a21b114c81735150b46917b76e2be690557ebc`

Significant changes

Benchmark	Mean	Status
root_hash_storage_hash	-2.61%	Performance has improved.
root_hash_all_par_storage	2.62%	Performance has degraded.
ptr_trie_insert_only_3000	-5.24%	Performance has improved.
gather_nodes_storage_tries	-2.96%	Performance has improved.

dvush approved these changes

View reviewed changes

ferranbt approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet