refactor properties with UserListProperty

Signed-off-by: flashdagger <flashdagger@googlemail.com>

zammadoo/groups.py

@@ -1,14 +1,13 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 -*-
 
-from typing import TYPE_CHECKING, List, Optional
+from typing import TYPE_CHECKING, Optional
 
-from .resource import NamedResource
+from .resource import NamedResource, UserListProperty
 from .resources import CreatableT, IterableT
 
 if TYPE_CHECKING:
     from .client import Client
-    from .users import User
 
 
 class Group(NamedResource):
@@ -17,19 +16,14 @@ class Group(NamedResource):
     parent: "Groups"  # type: ignore[assignment]
 
     shared_drafts: bool  #:
-    user_ids: List[int]  #:
+    users = UserListProperty()  #:
 
     @property
     def parent_group(self) -> Optional["Group"]:
         """available since Zammad version 6.2"""
         pid: int = self["parent_id"]
         return None if pid is None else self.parent(pid)
 
-    @property
-    def users(self) -> List["User"]:
-        users = self.parent.client.users
-        return [users(uid) for uid in self.user_ids]
-
 
 class Groups(IterableT[Group], CreatableT[Group]):
     """Groups(...)"""

zammadoo/organizations.py

@@ -1,32 +1,23 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 -*-
 
-from typing import TYPE_CHECKING, List
+from typing import TYPE_CHECKING
 
-from .resource import NamedResource
+from .resource import NamedResource, UserListProperty
 from .resources import CreatableT, SearchableT
 
 if TYPE_CHECKING:
     from .client import Client
-    from .users import User
 
 
 class Organization(NamedResource):
     """Organization(...)"""
 
-    shared: bool  #:
     domain: str  #:
     domain_assignment: bool  #:
-
-    @property
-    def members(self) -> List["User"]:
-        users = self.parent.client.users
-        return [users(mid) for mid in self["member_ids"]]
-
-    @property
-    def secondary_members(self) -> List["User"]:
-        users = self.parent.client.users
-        return [users(sec_mid) for sec_mid in self["secondary_member_ids"]]
+    members = UserListProperty()  #:
+    secondary_members = UserListProperty()  #:
+    shared: bool  #:
 
     @property
     def weburl(self) -> str:

zammadoo/resource.py

@@ -2,13 +2,12 @@
 # -*- coding: UTF-8 -*-
 
 from datetime import datetime
-from typing import TYPE_CHECKING, Any, Optional, Tuple
+from typing import TYPE_CHECKING, Any, List, Optional, Tuple
 
 from .resources import ResourcesT, _T_co
 from .utils import AttributeT, DateTime, FrozenInfo, _AttributeBase
 
 if TYPE_CHECKING:
-    # noinspection PyUnresolvedReferences
     from .users import User
     from .utils import JsonDict
 
@@ -71,6 +70,13 @@ def __get__(self, instance: Resource, owner=None) -> "User":
         return instance.parent.client.users(instance[f"{self.name}_id"])
 
 
+class UserListProperty(_AttributeBase):
+    def __get__(self, instance: Resource, owner=None) -> List["User"]:
+        user = instance.parent.client.users
+        uids = instance[f"{self.name[:-1]}_ids"]
+        return [user(uid) for uid in uids]
+
+
 class OptionalUserProperty(_AttributeBase):
     def __get__(self, instance: Resource, owner=None) -> Optional["User"]:
         value = instance[f"{self.name}_id"]