Simplify the wrapper API: Move all non-tensor arguments from forward to begin_forward
#443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
changed the title
forward to begin_forward
|
It seems #466 already fixed this. I will close this . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is duplication in the arguments of
forwardandbegin_forward. This PR moves all non-tensor arguments fromforwardtobegin_forward. The arguments will be cached in the wrapper and reused for all laterforward.This PR only changes
decode.py. If it looks good, I will proceed to updateprefill.py.I think it might be better to handle this on the C++ side, but I will limit this PR to Python.