Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix the python 3.8 type error #486

Merged
merged 1 commit into from
Sep 1, 2024
Merged

bugfix: fix the python 3.8 type error #486

merged 1 commit into from
Sep 1, 2024

Conversation

yzh119
Copy link
Collaborator

@yzh119 yzh119 commented Sep 1, 2024 •
edited
Loading

Bugfix to #484, thanks @wzhao18 for spotting this error.

@yzh119 yzh119 merged commit 77bff3f into main Sep 1, 2024
@yzh119 yzh119 mentioned this pull request Sep 1, 2024
Closed
@yzh119 yzh119 deleted the py38-cascade branch October 11, 2024 23:17
@yzh119 yzh119 mentioned this pull request Dec 12, 2024
Merged
yzh119 added a commit that referenced this pull request Dec 12, 2024
@yzh119
bugfix: fix type annotation error in python3.8 (#656)
4313654 
As mentioned in #653,
there is a type annotation error in cascade.py because we use `list`
which is builtin since python 3.9 (related PR
#486).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yzh119