Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert setuptools-scm #671

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Revert setuptools-scm #671

merged 3 commits into from
Dec 17, 2024

Conversation

ur4t
Copy link
Contributor

@ur4t ur4t commented Dec 17, 2024

No description provided.

@ur4t
Copy link
Contributor Author

ur4t commented Dec 17, 2024

@yzh119 @zhyncs setuptools-scm works poorly with Github actions and we should rather move back to version.txt managed by release-please-action than hack too further. Related PR flashinfer-ai/flashinfer-nightly#6 makes nightly CI works the same as release CI and maybe we can unify them someday.

yzh119
yzh119 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, let's try it later.

@yzh119 yzh119 merged commit d2ebd1e into flashinfer-ai:main Dec 17, 2024
@ur4t ur4t deleted the revert-setuptools-scm branch December 17, 2024 07:24
@ur4t ur4t mentioned this pull request Dec 17, 2024
Merged
@zhyncs zhyncs mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ur4t @yzh119