-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor entire extension code #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonla
force-pushed
the
42-extension-refactoring
branch
2 times, most recently
from
October 7, 2021 22:24
8fbfdbf
to
3ae7e7f
Compare
timonla
force-pushed
the
42-extension-refactoring
branch
from
October 11, 2021 19:42
b4b2fc9
to
0b0f009
Compare
Is there any documentation on how to build the extension the new way? |
Lyannic
requested changes
Oct 22, 2021
Lyannic
reviewed
Oct 22, 2021
Lyannic
requested changes
Oct 23, 2021
Lyannic
approved these changes
Oct 23, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run watch
is available to continuously build)dist/third-party
filesdist/content/
directory)content.ts
files are the files that are called on page enterTested to write reusable html blocks using
dom-chef
to mimic react jxs style but webcomponents work much better and offer much more functionality if we need it in the future.Injecting the webcomponents into the dom is not straight forward. Added a utility function (
component
) to aid this. It works fine as long as we don't want to pass any children (slot elements). I tried to enable easy injection with webcomponents anddom-chef
but we loose typing on complex webcomponent properties (arrays and objects) and have to use full lowercase property names. Restricting ourselves to only passing primitive types to the webcomponent works fine, so we can fall back onto that. The experiment is available at https://github.com/flashkillapp/flashkill/tree/dom-chef-webcomponents-test.There is a nice snippet included on how to create more webcomponents. More documentation to follow.
Resolves #42 #3 #39