Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues #195 to #201 #202

Merged
merged 23 commits into from
Dec 27, 2019
Merged

Issues #195 to #201 #202

merged 23 commits into from
Dec 27, 2019

Conversation

flashmob
Copy link
Owner

Fixes a few issues (see commits)

flashmob added 14 commits December 3, 2019 15:22
@flashmob
issue #195 - skip linear white-space between encoded words
669d62d
@flashmob
issue #196 - tiny redis bug (returning the wrong error)
ac7b710
@flashmob
issue #197 - support for ip addresses in allows_host setting
0258f19
@flashmob
issue #198 - remove helo/ehlo from the population on headers
a32e269
@flashmob
issue #199 - IP addresses are normalized, Address.String() returns an…
c08de3d 
… empty string of address is empty, or just "postmaster" it it's a postmaster address
@flashmob
issue #199 - add a new email address parser for emails found in messa…
29f1af0 
…ge headers
@flashmob
commenting & error pre-declare
c6eb2c9
@flashmob
eliminate the need for a temp buffer in MimeHeaderDecode
96b3a1f
@flashmob
refactoring: minimize allocations in MimeHeaderDecode
ff7d8af
@flashmob
refactoring MimeHeaderDecode to remove redundant code
3823330
@flashmob
use our new address parser instead of Go's stdlib one
3798997
@flashmob
validate ehlo and helo according to abnf
68f0de0
@flashmob
fix tests, for #200
f46543b
@flashmob
* fix tests, for #200
f9d4460 
* ensure <postmaster> RCPT TO is correctly handled, for #201
@flashmob flashmob mentioned this pull request Dec 13, 2019
Closed
@flashmob flashmob mentioned this pull request Dec 13, 2019
Closed
This was referenced Dec 13, 2019
Closed
Closed
Closed
Closed
Closed
@flashmob
Copy link
Owner Author

@flashmob flashmob changed the title Parser fixes Issues #195 to #201 Dec 13, 2019
@flashmob
Copy link
Owner Author

ping @issuefiler

@flashmob
adds 4 test-cases for issue #197
9d84286 
also adjusts the allowed hosts config so that IP addresses must be enclosed in braces.
a separate allowsIp function is used when the rcpt-to host is parsed as an address-literal
also fixes a bug where the IP address wasn't copied from the parser
@flashmob
add integration test for issue #200
7df15e2
@flashmob
integration test for issue #201
3a9daa1
@flashmob
integration test for issue #199
0fd6e5c 
also fixes a bugs:
- emails such as "user"@test.com do not need quoting
- Address.String() now outputs the IP around in braces
@flashmob
integration test for issue #198
54640d5
@flashmob
issue #195 - added additional test (a case where there was no space a…
5650cd0 
…fter decoded word)

- added more states to the machine to fix the above case
- Some tests were missed from the Makefile
@flashmob flashmob merged commit d8ea544 into master Dec 27, 2019
@issuefiler
Copy link

pong @flashmob.

Sorry, I think I’m a bit late to the cognac party.
Just updated my build to the latest and checked the new changes out. It looks good to me, too!
Thank you for the update.

@flashmob
Copy link
Owner Author

Thanks for checking in!

The latest master has been deployed on Guerrilla Mail too, so it's going through the ultimate battle test right now. Cheers!

@phires phires deleted the parser-fixes branch June 4, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flashmob @issuefiler