Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

coreos-base/afterburn: Restart on failure and keep unit active #768

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

pothos
Copy link
Contributor

@pothos pothos commented Jan 7, 2021

When the metadata server is unavailable for some time the service did
not retry. Also, the service was triggered possibly multiple times
each time another service pulled it in which can cause problems if,
e.g., the service experiences a failure and corrupts the existing file
which could have been kept because rerunning wasn't needed.

Fixes flatcar/Flatcar#311

How to use

Build and verify that all tests pass

Testing done

None

When the metadata server is unavailable for some time the service did
not retry. Also, the service was triggered possibly multiple times
each time another service pulled it in which can cause problems if,
e.g., the service experiences a failure and corrupts the existing file
which could have been kept because rerunning wasn't needed.

Fixes flatcar/Flatcar#311
@pothos pothos requested a review from a team January 7, 2021 19:27
Copy link
Contributor

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pothos pothos merged commit e5a3263 into main Jan 8, 2021
@pothos pothos deleted the kai/coreos-metadata-retry-remain branch January 8, 2021 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make one-shot units more robust
2 participants