Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run automatic tests for BPF before each Flatcar release #89

Closed
alban opened this issue Apr 22, 2020 · 2 comments
Closed

Run automatic tests for BPF before each Flatcar release #89

alban opened this issue Apr 22, 2020 · 2 comments
Labels
kind/feature A feature request kind/infrastructure Issues concerning build / test / release tooling or infrastructure of Flatcar Container Linux.

Comments

@alban
Copy link
Member

alban commented Apr 22, 2020

Current situation
As far as I know, we don't have tests for BPF integrated in the test/release pipeline.

Impact
Software using BPF might break if kernel bugs are introduced in new releases and it can more easily go unnoticed without automatic testing. As an example, Inspektor Gadget uses various BPF tools (from traceloop, tcptracer-bpf, BCC). We've had an issue with the BCC opensnoop tool in a Flatcar Edge release (see iovisor/bcc#2726).

Ideal future situation
Some basic tests of common BPF tools should be automatically executed before each release. Sometime, it can break because of a kernel bug, or because of a bug in the tool. It should be assessed to decide whether the release can go.

Implementation options
Some existing tests could be reused:

@alban alban added the kind/feature A feature request label Apr 22, 2020
@t-lo t-lo added the kind/infrastructure Issues concerning build / test / release tooling or infrastructure of Flatcar Container Linux. label Apr 22, 2020
@t-lo
Copy link
Member

t-lo commented Apr 23, 2020

#91 alone is a good reason for adding BPF tests.

@tormath1
Copy link
Contributor

Hi @alban,

Some tests have been added and more to come but the initial issue is solved:

As far as I know, we don't have tests for BPF integrated in the test/release pipeline.

We currently have:

bpf.execsnoop
bpf.local-gadget (dns gadget)

Thanks for submitting the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request kind/infrastructure Issues concerning build / test / release tooling or infrastructure of Flatcar Container Linux.
Projects
None yet
Development

No branches or pull requests

3 participants