test: add bpf test with DNS gadget from local-gadget #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
changed the title
this method is quite handy to generate Docker image based on host binaries. It helps to circumvent Docker rate limit and it also remove third-party dependencies. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/local-gadget
branch
from
0c1feba
to
b745f9c
Compare
pothos
reviewed
Dec 1, 2021
kola/tests/bpf/local-gadget.go
Outdated
| c.Fatalf("unable to run docker cmd: %v", err) | ||
| } | ||
|
|
||
| out, err := c.SSH(node, "cat /tmp/local-gadget.res | grep pkt_type | head --lines 1 | jq -r .name") |
There was a problem hiding this comment.
Suggested change
| out, err := c.SSH(node, "cat /tmp/local-gadget.res | grep pkt_type | head --lines 1 | jq -r .name") | |
| out, err := c.SSH(node, "grep -m 1 pkt_type /tmp/local-gadget.res | jq -r .name") |
This makes the processes run without error, not a real problem but if it gets copied later where pipefail is set, grep will fail when head terminates earlier because it does not consume the full input
There was a problem hiding this comment.
Thanks for the tip.
pothos
reviewed
Dec 1, 2021
| Run: localGadgetTest, | ||
| Name: `bpf.local-gadget`, | ||
| Distros: []string{"cl"}, | ||
| // required while SELinux policy is not correcly updated to support |
There was a problem hiding this comment.
let's see if it works on the current LTS, otherwise we can add a minimum version later
pothos
approved these changes
Dec 1, 2021
|
@pothos thanks for this quick review 😂 but it's still WIP, currently adding seccomp-gadget test. |
tormath1
force-pushed
the
tormath1/local-gadget
branch
from
b745f9c
to
57ea565
Compare
tormath1
changed the title
dongsupark
reviewed
Dec 3, 2021
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/local-gadget
branch
from
57ea565
to
589cc4a
Compare
dongsupark
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we test
IGand related BPF features on Flatcar withlocal-gadgetstarting with DNS gadget.We basically install
local-gadgetand prepare its run using CLC.It currently runs without SELinux due to this: flatcar/Flatcar#509
How to use
Testing done
Related-to: flatcar/Flatcar#89
It could be merged with: #233 to kickoff BPF tests on Flatcar.