Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip coreos-cloudinit if ignition is used #27

Conversation

gabriel-samfira
Copy link
Member

This change skips coreos-cloudinit when config drive is used, if the system was configured using ignition.

Building an image with this change now. Will report back once I manage to test it.

Addresses behavior seen in:

This change skips coreos-cloudinit when config drive is used, if the
system was configured using ignition.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
@pothos
Copy link
Member

pothos commented Mar 15, 2024

Can we merge this or does it need more testing? Afterwards we also need a scripts PR that bumps the commit ref.

@gabriel-samfira
Copy link
Member Author

Can we merge this or does it need more testing? Afterwards we also need a scripts PR that bumps the commit ref.

With the exclusion of OpenStack for this service, it is now skipped regardless of whether or not the system was configured via ignition or not:

flatcar ~ # systemctl status user-configdrive
○ user-configdrive.service - Load cloud-config from /media/configdrive
     Loaded: loaded (/usr/lib/systemd/system/user-configdrive.service; static)
     Active: inactive (dead)

On other platforms it should just skip configuring it because of the ExecCondition.

@pothos
Copy link
Member

pothos commented Mar 22, 2024

I've tested the condition in the possible cases it can hit and it looks good. You can click merge and open the scripts PR or if you are busy, also ok and I can do it :)

@gabriel-samfira
Copy link
Member Author

I've tested the condition in the possible cases it can hit and it looks good. You can click merge and open the scripts PR or if you are busy, also ok and I can do it :)

Sorry for the slowness on this. I was at Kubecon last week and just got back. I will create the scripts PR in the morning.

@gabriel-samfira gabriel-samfira merged commit f78b9f7 into flatcar:flatcar-master Mar 24, 2024
1 check passed
@gabriel-samfira gabriel-samfira deleted the disable-coreos-cloudinit branch March 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants