show-fixed-kernel-cve: use Python interpreter #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this it makes 'scripts' calls failing. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
chewi
approved these changes
Aug 28, 2024
| @@ -102,4 +104,4 @@ def fixed_linux_cves(f, t): | |||
|
|
|||
| cves = fixed_linux_cves(Version(options.from_version), Version(options.to_version)) | |||
| if len(cves) > 0: | |||
| print(f"- Linux ({cves})") | |||
There was a problem hiding this comment.
Why are we dropping the - Linux here?
There was a problem hiding this comment.
Good question :D I discovered yesterday that this script is actually used in our CI and it's called via show-changes here:
flatcar-build-scripts/show-changes
Lines 103 to 105 in fa46a1d
The - Linux (...) is already present in this case, and I minimize the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this it makes 'scripts' calls failing.
I noticed well after that this script is actually called from
show-changes