Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locksmithcl: reset endpoints when we set a new one #13

Merged
merged 1 commit into from
Aug 27, 2021

Commits on Aug 26, 2021

  1. locksmithcl: reset endpoints when we set a new one

    This behavior was working fine previously but no more with the etcd/v2
    upgrade.
    
    In the case we have an endpoint like `https://127.0.0.1:2379`, this one
    will be _added_ to the list of `defaultEndpoints` which lead to this
    endpoints:
    ```go
    []string{
    	"http://127.0.0.1:2379",
    	"http://127.0.0.1:4001",
    	"https://127.0.0.1:2379",
    }
    ```
    
    It's not an issue when we have a retry mechanism - but in this case if
    `etcd` use HTTPS and we try an `HTTP` endpoint, we will get an io.EOF
    error.
    
    Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
    Mathieu Tortuyaux committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    9287272 View commit details
    Browse the repository at this point in the history