fix check for systemd-timesyncd.service #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Mar 26, 2024
pothos
reviewed
Mar 26, 2024
pothos
reviewed
Mar 26, 2024
tormath1
reviewed
Mar 26, 2024
We're enabling ntpd/chronyd by default on certain OEM platforms, so rework the test to check that any ntp implementation is active. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
These show up on go 1.21 when running ./test. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/ntp-test-fix
branch
from
1d8d3ca
to
012b3c1
Compare
pothos
approved these changes
Mar 26, 2024
tormath1
approved these changes
Mar 26, 2024
The cl.update.oem test runs on Qemu but uses the Azure OEM payload. The Azure OEM payload will ship chronyd configured to talk to Hyper-Vs PTP device - which is not available in Qemu - and this fails the test. Mask chronyd to prevent the failure. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Test ran successfully. http://jenkins.infra.kinvolk.io:8080/job/container/job/test/20926/ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-timesyncd.service will not be the only ntp implementation enabled by default on all platforms, so the test needs to take that into account.