gce: Update default options #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some image/project/bucket names still reference coreos, switch to the correct flatcar values. n1-standard-1 instances are old and slightly more expensive than t2d-standard-1 so make those the default. We have also enabled "public access restriction" on our test bucket, so to get `ore gcloud upload` to work we need to switch the default object ACL to projectPrivate. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
tormath1
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some image/project/bucket names still reference coreos, switch to the correct flatcar values. n1-standard-1 instances are old and slightly more expensive than t2d-standard-1 so make those the default. We have also enabled "public access restriction" on our test bucket, so to get
ore gcloud uploadto work we need to switch the default object ACL to projectPrivate.