qemu: extract swtpm #522
Merged
qemu: extract swtpm #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Apr 10, 2024
pothos
reviewed
Apr 10, 2024
|
FYI, the qemu script with TPM support can already be downloaded here: https://bincache.flatcar-linux.net/images/amd64/3930.0.0+nightly-20240404-2100/flatcar_production_qemu_uefi.sh |
So that it can be added to kola spawn more easily. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Move swtpm creation from the tpm test to the qemu implementation. This allows it to be reused for various test cases. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/tpm-refactor
branch
from
fd17331
to
9de7932
Compare
pothos
approved these changes
Apr 11, 2024
Allow users to create a qemu VM with swtpm through kola spawn. CLI options are shared between `kola spawn` and `kola run` so add comments informing users that the option should not be used with `kola run`. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/tpm-refactor
branch
from
9de7932
to
613b6e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that kola spawn can support
--qemu-tpmfor testing.