kubeadm: run tests with sysext images #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
force-pushed
the
tormath1/kubernetes
branch
from
079e3e9
to
3ba6d0a
Compare
pothos
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Looks good, thanks!
We could rerun the Kubernetes test on all platforms or let the nightly do it next time.
Do you think we should have a clilium and help sysext image? These two are downloaded as plain binaries now and it might be good to keep them up-to-date, not so important for this test but it might be helpful for users.
* use systemd sysext instead of binaries * convert CLC to Butane configuration * remove useless variables * remove 'checksum.sh' Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This reverts commit bced13d. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/kubernetes
branch
from
3ba6d0a
to
154533b
Compare
|
Force pushed to update the testdata to be more consistent with reality. Will wait for the release to be done before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we test Kubernetes using the sysext images from the sysext-bakery. It eases the test writing as we remove the installation of Kubernetes components and we are actually testing sysext images that are being used in other projects (Kubernetes deployments and CAPI deployments).
Changes:
Testing done
Notes for reviewers
testdatacontent is generated fromtemplates.go, no need to check the content of this folder, onlytemplates.gois important