api/equinixmetal: allows using different port for webserver storage #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One can now provide a URL like: ssh+http://1.2.3.4:8088 to upload the temporary artifacts on server 1.2.3.4 via SSH and download the artifacts from http://1.2.3.4:8088 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
krnowak
reviewed
Nov 14, 2024
Yeah, it is not an emergency to get this merged so I did not insist on this review. For Equinix Metal, we boot an instance using PXE: PXE configuration and Ignition configuration can be stored on a Google Cloud Storage bucket or a regular HTTP server. This PR allows to configure SSH port and HTTP port. Before that, it was impossible to use an HTTP port different from 80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can now provide a URL like: ssh+http://1.2.3.4:8088 to upload the temporary artifacts on server 1.2.3.4 via SSH and download the artifacts from http://1.2.3.4:8088