Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: add board->arch mapping for Hetzner #553

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

apricote
Copy link
Contributor

Fix kolet binary architecture on Hetzner

Add a mapping for hetzner platform so the right kolet binary is uploaded.

Without this, kola would always upload the amd64 kolet, even for arm64 tests.

This failed with:

bash: line 1: ./kolet: cannot execute binary file: Exec format error

How to use

See flatcar/scripts#2142 for usage.

Testing done

Tested it locally with (only important flags):

bin/kola --board="arm64-usr" --platform hetzner --hetzner-server-type cax11 run cl.basic

Which failed without these changes and succeeds now.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Without this, kola would always upload the amd64 kolet, even for arm64
tests.

This fails with:

    bash: line 1: ./kolet: cannot execute binary file: Exec format error
@apricote
Copy link
Contributor Author

I do not really understand the purpose of the architecture function. Maybe this can be removed altogether?

@tormath1 tormath1 merged commit 71a8633 into flatcar:flatcar-master Sep 2, 2024
1 of 2 checks passed
@tormath1
Copy link
Contributor

tormath1 commented Sep 2, 2024

I do not really understand the purpose of the architecture function. Maybe this can be removed altogether?

Thanks - looks like I forgot this for Scaleway too 🤷 I'll investigate to understand "why" this function but I think we should remove the bounding between the platform and the tested board (i.e all the <platform>Options.Board should be dropped in favor of a generic one)

@apricote apricote deleted the kolet-hetzner-arm64 branch September 2, 2024 10:32
@apricote
Copy link
Contributor Author

apricote commented Sep 2, 2024

(i.e all the Options.Board should be dropped in favor of a generic one)

That is already the generic field from Options.Board that just get embedded in the platform options.

@tormath1
Copy link
Contributor

tormath1 commented Sep 3, 2024

(i.e all the Options.Board should be dropped in favor of a generic one)

That is already the generic field from Options.Board that just get embedded in the platform options.

Yeah - it looks like I already played with those part: 407bc17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants