WIP: proof-of-concept merge #513

illume · 2021-11-17T07:56:12Z

I reduced the proof-of-concept down to 7 commits without the meta data stuff. I left the proof-of-concept branch there, and made a new proof-of-concept2 branch.

Four groups of commits

backend: Add OIDC Login Token auth endpoint

Makefile: Run codegen in backend target

frontend: Allow to change and show application.product_id
backend: Validate apps' product-id format before setting the app
backend: Use a cache for quickly getting the apps' IDs
backend: Add human-readable applications.product_id

backend: Replace gin with oapi-codegen and echo

Testing done

Had CI run on each commit, so each commit passes all checks.

Previously we used gin server, this is replaced with oapi-codegen and echo to generate client and server stubs. This introduces a documentation first approach for new endpoints. Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>

A human readable product_id (app name) including a reverse domain is allowed since omaha version 3. This human-readable name is much easier to use compared to the long UUID id. Now either product_id or id can be used to identify applications.

So we're sure to have updated files when touching the backend. It's also better for CI since it may detect outdated generated files.

Adds a Login Token endpoint which authenticates the user against the OIDC provider without the need for browser flow. This endpoint can be used to authenticate programmatically. Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>

backend/pkg/api/applications.go

backend/pkg/api/groups.go

backend/pkg/handler/instances.go

backend/pkg/middleware/auth.go

backend/pkg/middleware/path.go

backend/pkg/sessions/echo/echo.go

backend/cmd/nebraska/main.go

backend/pkg/api/db/migrations/0014_add_application_product_id.sql

backend/pkg/api/applications.go

backend/pkg/api/db/migrations/0014_add_application_product_id.sql

backend/pkg/api/applications.go

frontend/src/js/components/Applications/EditDialog.tsx

backend/pkg/middleware/auth.go

backend/pkg/auth/oidc.go

backend/pkg/handler/app.go

backend/api/spec.yaml

backend/pkg/handler/groups.go

backend/api/spec.yaml

This patch reduces the default per page value at db level to 10 Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>

illume · 2022-01-03T12:22:53Z

I'm making a new squashed/rebased branch proof-of-concept3, and leaving this one around for history.

There's still a number of open conversations on here that I'll move into issues.

illume · 2022-01-03T22:01:30Z

New PR is here (commits squashed and rebased against main) #546
I added issues for all the open conversations.

Closing this one now.

illume force-pushed the proof-of-concept2 branch 3 times, most recently from ef66d21 to aff0a2d Compare November 17, 2021 09:19

backend: Replace gin with oapi-codegen and echo

e2bc2c0

Previously we used gin server, this is replaced with oapi-codegen and echo to generate client and server stubs. This introduces a documentation first approach for new endpoints. Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>

illume force-pushed the proof-of-concept2 branch from 799c396 to e2bc2c0 Compare November 17, 2021 15:22

joaquimrocha and others added 5 commits November 17, 2021 16:22

backend: Use a cache for quickly getting the apps' IDs

63c14ad

backend: Validate apps' product-id format before setting the app

3990c32

frontend: Allow to change and show application.product_id

241a58a

Makefile: Run codegen in backend target

206a00e

So we're sure to have updated files when touching the backend. It's also better for CI since it may detect outdated generated files.

illume force-pushed the proof-of-concept2 branch from 928176a to 206a00e Compare November 17, 2021 15:44

backend: Add OIDC Login Token auth endpoint

2e7bcbe

Adds a Login Token endpoint which authenticates the user against the OIDC provider without the need for browser flow. This endpoint can be used to authenticate programmatically. Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>